Fix: Use standard CMSIS constant for SCB SLEEPDEEP register access #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Use standard CMSIS constant for SCB SLEEPDEEP register access
Description
Addresses review feedback from #148:
M33_SCR_SLEEPDEEP_BITSwas used without proper definition. Replaced with standard CMSIS constantSCB_SCR_SLEEPDEEP_MskandSCB->SCRregister access.Changes:
#include <cmsis_core.h>for Cortex-M targetsscb_hw->scrwithSCB->SCRM33_SCR_SLEEPDEEP_BITSwithSCB_SCR_SLEEPDEEP_MskThis follows the standard pattern used throughout Zephyr for ARM Cortex-M SCB register access.
Related Issues/Tickets
How Has This Been Tested?
arch/arm/core/cortex_m/cpu_idle.c)Screenshots / Recordings (if applicable)
N/A
Checklist
Further Notes / Considerations
This is a stacked PR targeting #148. The CMSIS
SCB_SCR_SLEEPDEEP_Mskconstant is defined incore_cm33.hand included viacmsis_core.h→cmsis_core_m_defaults.hfor RP2350 (Cortex-M33) targets.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.